Skip to content

sweeper/aws_billing_view: Skips non-CUSTOM billing views #45348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

sweeper/aws_billing_view: Skips non-CUSTOM billing views #45348

wants to merge 2 commits into from
+12 −1

Conversation

@gdavison
Copy link
Contributor

@gdavison gdavison commented Dec 2, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Skips non-CUSTOM billing views

@gdavison gdavison requested a review from a team as a code owner December 2, 2025 00:21
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. sweeper Pertains to changes to or issues with the sweeper. service/billing Issues and PRs that pertain to the billing service. size/XS Managed by automation to categorize the size of a PR. labels Dec 2, 2025
ewbankkit
ewbankkit previously approved these changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Base automatically changed from b-resourceexplorer-sweep to main December 2, 2025 18:10
@gdavison gdavison dismissed ewbankkit’s stale review December 2, 2025 18:10

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ewbankkit ewbankkit ewbankkit left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/billing Issues and PRs that pertain to the billing service. size/XS Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gdavison @ewbankkit